PHPStan level 9 #286
Merged
PHPStan level 9 #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
commented
Jul 1, 2025
Comment on lines
-2194
to
-2196
| if ( false === $modes ) { | ||
| $modes = []; | ||
| } |
swissspidy
commented
Jul 1, 2025
Comment on lines
-2158
to
-2162
| foreach ( [] as $arg ) { | ||
| if ( isset( $assoc_args[ $arg ] ) ) { | ||
| $args[ $arg ] = $assoc_args[ $arg ]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Looping through an empty array does nothing
swissspidy
commented
Jul 1, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
schlessera
previously requested changes
Jul 7, 2025
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
mrsdizzie
approved these changes
Jul 22, 2025
|
This looks ok to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: